Fix/windows conpty ansi leak - #857
Conversation
|
Hopefully this fixes Codebuff/Freebuff! |
|
Thanks! Coding agent thought it was a reasonable fix. Merged a version of this |
|
The instinct here is reasonable — unifying process-group behavior across platforms so grandchild processes get killed consistently on timeout/abort. But the justification in the new comment is not accurate: Node's That matters here because the original code deliberately set Given the PR is only a comment + one flag change with no test coverage, no repro steps, and no evidence the ANSI-leak scenario was actually verified on Windows post-change, this needs more rigor before it can be ported: either a reproduction script/test demonstrating the leak is fixed with |
No description provided.